Throw FileSystemException from FileSystemEntity methods.

Throw FileSystemException from FileSystemEntity methods.

We need to be able to handle exceptions regardless of the implementation.

R=paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/48b22b0e526111a4f1fad0b61919213438cceaed

[Paul Berry, 2017-05-07 14:06:49]

https://codereview.chromium.org/2864183002/diff/1/pkg/front_end/lib/physical_...
File pkg/front_end/lib/physical_file_system.dart (right):

https://codereview.chromium.org/2864183002/diff/1/pkg/front_end/lib/physical_...
pkg/front_end/lib/physical_file_system.dart:59: throw new
FileSystemException(uri, exception.message);
The logic you're removing from
pkg/front_end/lib/src/fasta/source/source_loader.dart prefers e.osError?.message
when available.  Should we replicate that logic here?

[scheglov, 2017-05-07 15:55:26]

PTAL

https://codereview.chromium.org/2864183002/diff/1/pkg/front_end/lib/physical_...
File pkg/front_end/lib/physical_file_system.dart (right):

https://codereview.chromium.org/2864183002/diff/1/pkg/front_end/lib/physical_...
pkg/front_end/lib/physical_file_system.dart:59: throw new
FileSystemException(uri, exception.message);
On 2017/05/07 14:06:49, Paul Berry wrote:
> The logic you're removing from
> pkg/front_end/lib/src/fasta/source/source_loader.dart prefers
e.osError?.message
> when available.  Should we replicate that logic here?

Done.

[Paul Berry, 2017-05-08 12:57:58]

lgtm

[scheglov, 2017-05-08 15:27:56]

Description was changed from

==========
Throw FileSystemException from FileSystemEntity methods.

We need to be able to handle exceptions regardless of the implementation.

R=paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Throw FileSystemException from FileSystemEntity methods.

We need to be able to handle exceptions regardless of the implementation.

R=paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/48b22b0e526111a4f1fad0b61919213438cceaed
==========

[scheglov, 2017-05-08 15:27:57]

Committed patchset #2 (id:20001) manually as
48b22b0e526111a4f1fad0b61919213438cceaed (presubmit successful).