Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 2864103003: Limit the number of history urls indexed for omnibox suggestions. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index 378027ff0bc2748b7e25fac1086ed2b30034d053..b50284d3cbd3439dc5970fa2dd94eba6c3c5df70 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -14,6 +14,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
+#include "base/sys_info.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "components/metrics/proto/omnibox_event.pb.h"
@@ -444,6 +445,19 @@ float OmniboxFieldTrial::HQPExperimentalTopicalityThreshold() {
return static_cast<float>(topicality_threshold);
}
+int OmniboxFieldTrial::MaxNumHQPUrlsIndexedAtStartup() {
+ const char* param = kMaxNumHQPUrlsIndexedAtStartupOnNonLowEndDevicesParam;
+ if (base::SysInfo::IsLowEndDevice())
+ param = kMaxNumHQPUrlsIndexedAtStartupOnLowEndDevicesParam;
+ std::string param_value(variations::GetVariationParamValue(
+ kBundledExperimentFieldTrialName, param));
+ int num_urls;
+ if (base::StringToInt(param_value, &num_urls))
+ return num_urls;
+ // Default value is set to -1 for unlimited number of urls.
+ return -1;
+}
+
bool OmniboxFieldTrial::HQPFixFewVisitsBug() {
return variations::GetVariationParamValue(
kBundledExperimentFieldTrialName,
@@ -721,6 +735,13 @@ const char
OmniboxFieldTrial::kHQPExperimentalScoringTopicalityThresholdParam[] =
"HQPExperimentalScoringTopicalityThreshold";
+const char
+ OmniboxFieldTrial::kMaxNumHQPUrlsIndexedAtStartupOnLowEndDevicesParam[] =
+ "MaxNumHQPUrlsIndexedAtStartupOnLowEndDevices";
+const char
+ OmniboxFieldTrial::kMaxNumHQPUrlsIndexedAtStartupOnNonLowEndDevicesParam[] =
+ "MaxNumHQPUrlsIndexedAtStartupOnNonLowEndDevices";
+
const char OmniboxFieldTrial::kPhysicalWebZeroSuggestBaseRelevanceParam[] =
"PhysicalWebZeroSuggestBaseRelevance";
const char OmniboxFieldTrial::kPhysicalWebAfterTypingBaseRelevanceParam[] =
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.h ('k') | components/omnibox/browser/url_index_private_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698