Limit the number of history urls indexed for omnibox suggestions.

components/history/core/browser/url_database_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/history/core/browser/keyword_search_term.h"
 #include "components/history/core/browser/url_database.h"
@@ skipping 216 matching lines @@
 
   // Delete the url.
   ASSERT_TRUE(DeleteURLRow(url_id));
 
   // Make sure the keyword visit was deleted.
   std::vector<KeywordSearchTermVisit> matches;
   GetMostRecentKeywordSearchTerms(1, base::UTF8ToUTF16("visit"), 10, &matches);
   ASSERT_EQ(0U, matches.size());
 }
 
 TEST_F(URLDatabaseTest, EnumeratorForSignificant) {

[Mark P, 2017/05/08 22:39:17]

Please restructure this test a bit.  Right now, for example, if enumerator
simply returned suggestions in a first-added-first-out order, it would pass the
test.

[ssid, 2017/05/10 01:01:35]

good point. Done.

-  std::set<std::string> good_urls;
+  // Vector contains urls in order of significance.
+  std::vector<std::string> good_urls;
+
   // Add URLs which do and don't meet the criteria.
   URLRow url_no_match(GURL("http://www.url_no_match.com/"));
   EXPECT_TRUE(AddURL(url_no_match));
 
-  std::string url_string2("http://www.url_match_visit_count.com/");
-  good_urls.insert("http://www.url_match_visit_count.com/");
-  URLRow url_match_visit_count(GURL("http://www.url_match_visit_count.com/"));
-  url_match_visit_count.set_visit_count(kLowQualityMatchVisitLimit);
-  EXPECT_TRUE(AddURL(url_match_visit_count));
+  good_urls.push_back("http://www.url_match_higher_typed_count.com/");
+  URLRow url_match_typed_count1(
+      GURL("http://www.url_match_higher_typed_count.com/"));
+  url_match_typed_count1.set_typed_count(kLowQualityMatchTypedLimit + 1);
+  EXPECT_TRUE(AddURL(url_match_typed_count1));
 
-  good_urls.insert("http://www.url_match_typed_count.com/");
-  URLRow url_match_typed_count(GURL("http://www.url_match_typed_count.com/"));
-  url_match_typed_count.set_typed_count(kLowQualityMatchTypedLimit);
-  EXPECT_TRUE(AddURL(url_match_typed_count));
+  good_urls.push_back("http://www.url_match_typed_count.com/");
+  URLRow url_match_typed_count2(GURL("http://www.url_match_typed_count.com/"));
+  url_match_typed_count2.set_typed_count(kLowQualityMatchTypedLimit);
+  EXPECT_TRUE(AddURL(url_match_typed_count2));
 
-  good_urls.insert("http://www.url_match_last_visit.com/");
-  URLRow url_match_last_visit(GURL("http://www.url_match_last_visit.com/"));
-  url_match_last_visit.set_last_visit(Time::Now() - TimeDelta::FromDays(1));
-  EXPECT_TRUE(AddURL(url_match_last_visit));
+  good_urls.push_back("http://www.url_match_last_visit.com/");
+  URLRow url_match_last_visit1(GURL("http://www.url_match_last_visit.com/"));
+  url_match_last_visit1.set_last_visit(Time::Now() - TimeDelta::FromDays(1));
+  EXPECT_TRUE(AddURL(url_match_last_visit1));
+
+  good_urls.push_back("http://www.url_match_last_visit2.com/");
+  URLRow url_match_last_visit2(GURL("http://www.url_match_last_visit2.com/"));
+  url_match_last_visit2.set_last_visit(Time::Now() - TimeDelta::FromDays(2));
+  EXPECT_TRUE(AddURL(url_match_last_visit2));
+
+  good_urls.push_back("http://www.url_match_higher_visit_count.com/");
+  URLRow url_match_visit_count1(
+      GURL("http://www.url_match_higher_visit_count.com/"));
+  url_match_visit_count1.set_visit_count(kLowQualityMatchVisitLimit + 1);
+  EXPECT_TRUE(AddURL(url_match_visit_count1));
+
+  good_urls.push_back("http://www.url_match_visit_count.com/");
+  URLRow url_match_visit_count2(GURL("http://www.url_match_visit_count.com/"));
+  url_match_visit_count2.set_visit_count(kLowQualityMatchVisitLimit);
+  EXPECT_TRUE(AddURL(url_match_visit_count2));
 
   URLRow url_no_match_last_visit(GURL(
       "http://www.url_no_match_last_visit.com/"));
   url_no_match_last_visit.set_last_visit(Time::Now() -
       TimeDelta::FromDays(kLowQualityMatchAgeLimitInDays + 1));
   EXPECT_TRUE(AddURL(url_no_match_last_visit));
 
   URLDatabase::URLEnumerator history_enum;
   EXPECT_TRUE(InitURLEnumeratorForSignificant(&history_enum));
   URLRow row;
   int row_count = 0;
   for (; history_enum.GetNextURL(&row); ++row_count)
-    EXPECT_EQ(1U, good_urls.count(row.url().spec()));
-  EXPECT_EQ(3, row_count);
+    EXPECT_EQ(good_urls[row_count], row.url().spec());
+  EXPECT_EQ(6, row_count);
 }
 
 // Test GetKeywordSearchTermRows and DeleteSearchTerm
 TEST_F(URLDatabaseTest, GetAndDeleteKeywordSearchTermByTerm) {
   URLRow url_info1(GURL("http://www.google.com/"));
   url_info1.set_title(base::UTF8ToUTF16("Google"));
   url_info1.set_visit_count(4);
   url_info1.set_typed_count(2);
   url_info1.set_last_visit(Time::Now() - TimeDelta::FromDays(1));
   url_info1.set_hidden(false);
@@ skipping 153 matching lines @@
   EXPECT_TRUE(AddURL(url_info5));
 
   URLRow info5;
   EXPECT_TRUE(GetRowForURL(url5, &info5));
   EXPECT_TRUE(IsURLRowEqual(url_info5, info5));
   // Verify the id is not re-used.
   EXPECT_NE(info4.id(), info5.id());
 }
 
 }  // namespace history