[Isolates] Statics 7: ExternalReference*/Simulator/dtoa...

[Isolates] Statics 7: ExternalReference*/Simulator/dtoa

- Fix up ExternalReference{Table|Encoder|Decoder} for multiple isolates.
- Define MULTIPLE_THREADS for dtoa.
- Fix up the simulator for multiple isolates.


Committed: http://code.google.com/p/v8/source/detail?r=5005

[zarko, 2010-06-30 23:36:56]

code. was returning 500s hence the multiple 'lint' weirdness.

Thanks
  Luke

[Maxim.Mossienko, 2010-07-01 07:52:14]

http://codereview.chromium.org/2864032/diff/31001/32006
File src/isolate.h (right):

http://codereview.chromium.org/2864032/diff/31001/32006#newcode825
src/isolate.h:825: #if defined(V8_TARGET_ARCH_ARM) && !defined(__arm__)
code probably would benefit from class ArmSimulator with this stuff

http://codereview.chromium.org/2864032/diff/31001/32007
File src/platform-linux.cc (right):

http://codereview.chromium.org/2864032/diff/31001/32007#newcode864
src/platform-linux.cc:864: static Mutex* dtoa_lock_zero = OS::CreateMutex();
Why we need several ACQUIRE_DTOA_LOCK / FREE_DTOA_LOCK with the same code? The
code itself should work for Windows/ other platforms too :)

[Vitaly Repeshko, 2010-07-01 21:10:07]

http://codereview.chromium.org/2864032/diff/31001/32003
File src/arm/simulator-arm.h (right):

http://codereview.chromium.org/2864032/diff/31001/32003#newcode345
src/arm/simulator-arm.h:345: return
assembler::arm::Simulator::current(v8::internal::Isolate::Current())
nit: Split the line before "v8".

http://codereview.chromium.org/2864032/diff/31001/32007
File src/platform-linux.cc (right):

http://codereview.chromium.org/2864032/diff/31001/32007#newcode872
src/platform-linux.cc:872: void ACQUIRE_DTOA_LOCK(int n) {
Move these functions to dtoa-config.c. Nothing platform-dependent here.

[zarko, 2010-07-01 21:36:48]

On 2010/07/01 21:10:07, Vitaly wrote:
> http://codereview.chromium.org/2864032/diff/31001/32003
> File src/arm/simulator-arm.h (right):
> 
> http://codereview.chromium.org/2864032/diff/31001/32003#newcode345
> src/arm/simulator-arm.h:345: return
> assembler::arm::Simulator::current(v8::internal::Isolate::Current())
> nit: Split the line before "v8".
> 
> http://codereview.chromium.org/2864032/diff/31001/32007
> File src/platform-linux.cc (right):
> 
> http://codereview.chromium.org/2864032/diff/31001/32007#newcode872
> src/platform-linux.cc:872: void ACQUIRE_DTOA_LOCK(int n) {
> Move these functions to dtoa-config.c. Nothing platform-dependent here.

I think I got these. I couldn't move those functions into dtoa-config.c because
they do things C doesn't care for, so I dropped them in conversions.cc instead
(which I thought was the nearest logical place for them).

Thanks!

[Vitaly Repeshko, 2010-07-01 21:43:27]

LGTM with a few nits.

http://codereview.chromium.org/2864032/diff/16003/49004
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/2864032/diff/16003/49004#newcode499
src/arm/simulator-arm.cc:499: void Simulator::FlushICache(v8::internal::HashMap*
i_cache, void* start_addr,
nit: One arg per line.

http://codereview.chromium.org/2864032/diff/16003/49004#newcode534
src/arm/simulator-arm.cc:534: void
Simulator::FlushOnePage(v8::internal::HashMap* i_cache, intptr_t start,
Ditto.

http://codereview.chromium.org/2864032/diff/16003/49006
File src/conversions.cc (right):

http://codereview.chromium.org/2864032/diff/16003/49006#newcode1165
src/conversions.cc:1165: void ACQUIRE_DTOA_LOCK(int n) {
ASSERT(n == 0 || n == 1)

http://codereview.chromium.org/2864032/diff/16003/49006#newcode1171
src/conversions.cc:1171: (n == 0 ? v8::internal::dtoa_lock_zero :
v8::internal::dtoa_lock_one)->
Ditto.

http://codereview.chromium.org/2864032/diff/16003/49007
File src/dtoa-config.c (right):

http://codereview.chromium.org/2864032/diff/16003/49007#newcode88
src/dtoa-config.c:88: /* Definitions for dtoa's ACQUIRE_DTOA_LOCK and
FREE_DTOA_LOCK are in
Thanks for adding this comment.