Issue 286403004: Add default value for second argument of CSSComputedStyleDeclaration::getPropertyCSSValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286403004: Add default value for second argument of CSSComputedStyleDeclaration::getPropertyCSSValue() (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
dstockwell, pdr., esprehn

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add default value for second argument of CSSComputedStyleDeclaration::getPropertyCSSValue() Add default value for second argument of CSSComputedStyleDeclaration::getPropertyCSSValue() instead of overloading. This avoids incurring the cost of an extra function call (since the overload was not inlined) only to provide UpdateLayout as default value for the EUpdateLayout argument. R=esprehn@chromium.org, dstockwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174394

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	Source/core/css/CSSComputedStyleDeclaration.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/css/CSSComputedStyleDeclaration.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/286403004/1

6 years, 7 months ago (2014-05-20 18:21:40 UTC) #5

Message was sent while issue was closed.

Change committed as 174394

Expand Messages | Collapse Messages