Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2863973003: Expose RTT and downlink bandwidth using experimental Javascript API (Closed)
Patch Set: kinuko comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index b68636a32525687261cc8d298c5a8beefbbf101f..825060998afde29040519adb4e073ea36a467b01 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -447,6 +447,14 @@ class NET_EXPORT NetworkQualityEstimator
const base::TimeTicks& start_time,
int percentile) const;
+ // Notifies the observers of RTT or throughput estimates computation.
+ virtual void NotifyObserversOfRTTOrThroughputComputed() const;
+
+ // Notifies |observer| of the current RTT and throughput if |observer| is
+ // still registered as an observer.
+ virtual void NotifyRTTAndThroughputEstimatesObserverIfPresent(
+ RTTAndThroughputEstimatesObserver* observer) const;
+
// Observer list for RTT or throughput estimates. Protected for testing.
base::ObserverList<RTTAndThroughputEstimatesObserver>
rtt_and_throughput_estimates_observer_list_;
@@ -569,19 +577,11 @@ class NET_EXPORT NetworkQualityEstimator
// Notifies observers of a change in effective connection type.
void NotifyObserversOfEffectiveConnectionTypeChanged();
- // Notifies the observers of RTT or throughput estimates computation.
- void NotifyObserversOfRTTOrThroughputComputed() const;
-
// Notifies |observer| of the current effective connection type if |observer|
// is still registered as an observer.
void NotifyEffectiveConnectionTypeObserverIfPresent(
EffectiveConnectionTypeObserver* observer) const;
- // Notifies |observer| of the current RTT and throughput if |observer| is
- // still registered as an observer.
- void NotifyRTTAndThroughputEstimatesObserverIfPresent(
- RTTAndThroughputEstimatesObserver* observer) const;
-
// Records NQE accuracy metrics. |measuring_duration| should belong to the
// vector returned by AccuracyRecordingIntervals().
// RecordAccuracyAfterMainFrame should be called |measuring_duration| after a

Powered by Google App Engine
This is Rietveld 408576698