Expose RTT and downlink bandwidth using experimental Javascript API

net/nqe/network_quality_estimator_test_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_NQE_NETWORK_QUALITY_ESTIMATOR_TEST_UTIL_H_
 #define NET_NQE_NETWORK_QUALITY_ESTIMATOR_TEST_UTIL_H_
 
 #include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/optional.h"
 #include "base/time/time.h"
 #include "net/base/network_change_notifier.h"
 #include "net/log/net_log.h"
+#include "net/log/test_net_log.h"
 #include "net/nqe/effective_connection_type.h"
 #include "net/nqe/network_quality_estimator.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace net {
 
-class BoundTestNetLog;
 class ExternalEstimateProvider;
 
 // Helps in setting the current network type and id.
 class TestNetworkQualityEstimator : public NetworkQualityEstimator {
  public:
   TestNetworkQualityEstimator();
 
   explicit TestNetworkQualityEstimator(
       const std::map<std::string, std::string>& variation_params);
 
   TestNetworkQualityEstimator(
       const std::map<std::string, std::string>& variation_params,
       std::unique_ptr<net::ExternalEstimateProvider>
           external_estimate_provider);
 
   TestNetworkQualityEstimator(
       std::unique_ptr<net::ExternalEstimateProvider> external_estimate_provider,
       const std::map<std::string, std::string>& variation_params,
       bool allow_local_host_requests_for_tests,
       bool allow_smaller_responses_for_tests,
       bool add_default_platform_observations,
       std::unique_ptr<BoundTestNetLog> net_log);
 
+  TestNetworkQualityEstimator(
+      std::unique_ptr<net::ExternalEstimateProvider> external_estimate_provider,
+      const std::map<std::string, std::string>& variation_params,
+      bool allow_local_host_requests_for_tests,
+      bool allow_smaller_responses_for_tests,
+      bool add_default_platform_observations,
+      bool suppress_notifications_for_testing,

[dcheng, 2017/05/17 12:27:46]

FWIW, this is a lot of bools. I guess it's just extending the existing ones, but
it may be useful to consider policy enums/constants to control test behavior at
some point.

[tbansal1, 2017/05/18 00:10:29]

Agreed. I will fix it, but I will prefer to do that in a separate CL.

+      std::unique_ptr<BoundTestNetLog> net_log);
+
   ~TestNetworkQualityEstimator() override;
 
   // Runs one URL request to completion.
   void RunOneRequest();
 
   // Overrides the current network type and id.
   // Notifies network quality estimator of a change in connection.
   void SimulateNetworkChange(
       NetworkChangeNotifier::ConnectionType new_connection_type,
       const std::string& network_id);
@@ skipping 41 matching lines @@
   // then the base implementation is called. |http_rtt|, |transport_rtt| and
   // |downstream_throughput_kbps| are set to the values that were previously
   // set by calling set_recent_http_rtt(), set_recent_transport_rtt()
   // and set_recent_transport_rtt() methods, respectively.
   EffectiveConnectionType GetRecentEffectiveConnectionTypeAndNetworkQuality(
       const base::TimeTicks& start_time,
       base::TimeDelta* http_rtt,
       base::TimeDelta* transport_rtt,
       int32_t* downstream_throughput_kbps) const override;
 
+  void NotifyObserversOfRTTOrThroughputComputed() const override;
+
+  void NotifyRTTAndThroughputEstimatesObserverIfPresent(
+      RTTAndThroughputEstimatesObserver* observer) const override;
+
   void set_start_time_null_http_rtt(const base::TimeDelta& http_rtt) {
     // Callers should not set effective connection type along with the
     // lower-layer metrics.
     DCHECK(!effective_connection_type_ && !recent_effective_connection_type_);
     start_time_null_http_rtt_ = http_rtt;
   }
 
   void set_recent_http_rtt(const base::TimeDelta& recent_http_rtt) {
     // Callers should not set effective connection type along with the
     // lower-layer metrics.
@@ skipping 131 matching lines @@
   base::Optional<int32_t> start_time_null_downlink_throughput_kbps_;
   base::Optional<int32_t> recent_downlink_throughput_kbps_;
 
   // If set, GetRTTEstimateInternal() would return the set value.
   base::Optional<base::TimeDelta> rtt_estimate_internal_;
 
   double rand_double_;
 
   LocalHttpTestServer embedded_test_server_;
 
+  // If true, notifications are not sent to any of the observers.
+  const bool suppress_notifications_for_testing_;
+
   // Net log provided to network quality estimator.
   std::unique_ptr<net::BoundTestNetLog> net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(TestNetworkQualityEstimator);
 };
 
 }  // namespace net
 
 #endif  // NET_NQE_NETWORK_QUALITY_ESTIMATOR_TEST_UTIL_H_