Expose RTT and downlink bandwidth using experimental Javascript API

third_party/WebKit/Source/modules/netinfo/NetworkInformation.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NetworkInformation_h
 #define NetworkInformation_h
 
 #include "core/dom/ContextLifecycleObserver.h"
 #include "core/events/EventTarget.h"
 #include "platform/bindings/ActiveScriptWrappable.h"
@@ skipping 11 matching lines @@
       public NetworkStateNotifier::NetworkStateObserver {
   USING_GARBAGE_COLLECTED_MIXIN(NetworkInformation);
   DEFINE_WRAPPERTYPEINFO();
 
  public:
   static NetworkInformation* Create(ExecutionContext*);
   ~NetworkInformation() override;
 
   String type() const;
   double downlinkMax() const;
+  double rtt() const;
+  double downlink() const;
 
   // NetworkStateObserver overrides.
-  void ConnectionChange(WebConnectionType, double downlink_max_mbps) override;
+  void ConnectionChange(WebConnectionType,
+                        double downlink_max_mbps,
+                        int http_rtt_msec,
+                        int transport_rtt_msec,
+                        double downlink_throughput_mbps) override;

[bengr, 2017/05/12 19:09:55]

Names are weird. Either do s/downlink_max_mbps/downlink_throughput_max_mbps/ or
s/downlink_throughput_mbps/downlink_mbps/.

[tbansal1, 2017/05/12 22:18:17]

Done.

 
   // EventTarget overrides.
   const AtomicString& InterfaceName() const override;
   ExecutionContext* GetExecutionContext() const override;
   void RemoveAllEventListeners() override;
 
   // ScriptWrappable
   bool HasPendingActivity() const final;
 
   // ContextLifecycleObserver overrides.
   void ContextDestroyed(ExecutionContext*) override;
 
   DECLARE_VIRTUAL_TRACE();
 
   DEFINE_ATTRIBUTE_EVENT_LISTENER(change);
   DEFINE_ATTRIBUTE_EVENT_LISTENER(typechange);  // Deprecated
 
  protected:
   // EventTarget overrides.
   void AddedEventListener(const AtomicString& event_type,
                           RegisteredEventListener&) final;
   void RemovedEventListener(const AtomicString& event_type,
                             const RegisteredEventListener&) final;
 
  private:
   explicit NetworkInformation(ExecutionContext*);
   void StartObserving();
   void StopObserving();
 
-  // Touched only on context thread.
+  // Variables below are touched only on context thread.
   WebConnectionType type_;
-
-  // Touched only on context thread.
   double downlink_max_mbps_;
+  int transport_rtt_msec_;
+  double downlink_throughput_mbps_;

[bengr, 2017/05/12 19:09:55]

Names are similarly weird.

[tbansal1, 2017/05/12 22:18:17]

Done.

 
   // Whether this object is listening for events from NetworkStateNotifier.
   bool observing_;
 
   // Whether ContextLifecycleObserver::contextDestroyed has been called.
   bool context_stopped_;
 };
 
 }  // namespace blink
 
 #endif  // NetworkInformation_h