Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/metrics/histograms/enums.xml

Issue 2863913003: Uses fine grained histogram buckets for CVC errors. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/enums.xml
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index e7ab6072226259de232d5a86d81b90b7a2263634..086e151c9d6df72e9af8235f878716840bbb01a3 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -1614,17 +1614,17 @@ uploading your change for review. These are checked by presubmit scripts.
<enum name="AutofillCardUploadDecisionMetric" type="int">
<int value="0" label="Upload offered"/>
- <int value="1" label="Upload not offered, no CVC detected"/>
sebsg 2017/05/05 15:15:31 You should keep the ones that don't change like "n
csashi 2017/05/05 16:29:55 Acknowledged. I thought it was safe to change this
sebsg 2017/05/05 16:46:31 Oh I forgot you changed the whole histogram name f
- <int value="2" label="Upload not offered, no address available"/>
- <int value="3" label="Upload not offered, no name available"/>
- <int value="4"
+ <int value="1" label="CVC field not detected"/>
+ <int value="2" label="CVC value not filled in detected CVC field"/>
+ <int value="3" label="Invalid CVC value filled in detected CVC field"/>
+ <int value="4" label="Upload not offered, no address available"/>
+ <int value="5" label="Upload not offered, no name available"/>
+ <int value="6"
label="Upload not offered, addresses had conflicting zip codes"/>
- <int value="5" label="Upload not offered, no zip code available"/>
- <int value="6" label="Upload not offered, get upload details RPC failed"/>
- <int value="7"
+ <int value="7" label="Upload not offered, no zip code available"/>
+ <int value="8"
label="Upload not offered, card and/or addresses had conflicting names"/>
- <int value="8" label="Upload offered, no CVC detected"/>
- <int value="9" label="Upload not offered"/>
+ <int value="9" label="Upload not offered, get upload details RPC failed"/>
</enum>
<enum name="AutofillCreditCardInfoBar" type="int">

Powered by Google App Engine
This is Rietveld 408576698