Uses fine grained histogram buckets for CVC errors.

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 #include <utility>
@@ skipping 77 matching lines @@
   enum AutofillFormSubmittedState {
     NON_FILLABLE_FORM_OR_NEW_DATA,
     FILLABLE_FORM_AUTOFILLED_ALL,
     FILLABLE_FORM_AUTOFILLED_SOME,
     FILLABLE_FORM_AUTOFILLED_NONE_DID_SHOW_SUGGESTIONS,
     FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS,
     AUTOFILL_FORM_SUBMITTED_STATE_ENUM_SIZE,
   };
 
   enum CardUploadDecisionMetric {
-    // All the required conditions were satisfied and the card upload prompt was
-    // triggered.
+    // All the required conditions were satisfied using either the form fields
+    // or we prompted the user to fix one or more conditions in the card upload
+    // prompt.
     UPLOAD_OFFERED = 1 << 0,
-    // No CVC was detected. We don't know whether any addresses were available
-    // nor whether we would have been able to get upload details.
-    UPLOAD_NOT_OFFERED_NO_CVC = 1 << 1,
+    // CVC field was not found in the form.
+    CVC_FIELD_NOT_FOUND = 1 << 1,

[sebsg, 2017/05/05 15:15:31]

Please see the comment I wrote in the histograms page.

[csashi, 2017/05/05 16:29:55]

Acknowledged. That comment looks correct to me even with this change.

[sebsg, 2017/05/05 16:46:30]

Oh sorry it was not about the comment, it was about the values :)

+    // CVC field was found, but field did not have a value.
+    CVC_VALUE_NOT_FOUND = 1 << 2,
+    // CVC field had a value, but it was not valid for the card network.
+    INVALID_CVC_VALUE = 1 << 3,
     // A CVC was detected but no recently created or used address was available.
     // We don't know whether we would have been able to get upload details.
-    UPLOAD_NOT_OFFERED_NO_ADDRESS = 1 << 2,
+    UPLOAD_NOT_OFFERED_NO_ADDRESS = 1 << 4,
     // A CVC and one or more addresses were available but no name was found on
-    // either the card or the adress(es). We don't know whether the address(es)
+    // either the card or the address(es). We don't know whether the address(es)
     // were otherwise valid nor whether we would have been able to get upload
     // details.
-    UPLOAD_NOT_OFFERED_NO_NAME = 1 << 3,
-    // A CVC, multiple addresses, and a name were available but the adresses had
+    UPLOAD_NOT_OFFERED_NO_NAME = 1 << 5,
+    // A CVC, multiple addresses, and a name were available but the addresses
+    // had
     // conflicting zip codes. We don't know whether we would have been able to
     // get upload details.
-    UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS = 1 << 4,
+    UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS = 1 << 6,
     // A CVC, one or more addresses, and a name were available but no zip code
-    // was found on any of the adress(es). We don't know whether we would have
+    // was found on any of the address(es). We don't know whether we would have
     // been able to get upload details.
-    UPLOAD_NOT_OFFERED_NO_ZIP_CODE = 1 << 5,
-    // A CVC, one or more valid addresses, and a name were available but the
-    // request to Payments for upload details failed.
-    UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED = 1 << 6,
+    UPLOAD_NOT_OFFERED_NO_ZIP_CODE = 1 << 7,
     // A CVC and one or more addresses were available but the names on the card
     // and/or the addresses didn't match. We don't know whether the address(es)
     // were otherwise valid nor whether we would have been able to get upload
     // details.
-    UPLOAD_NOT_OFFERED_CONFLICTING_NAMES = 1 << 7,
-    // No CVC was detected, but valid addresses and names were.  Upload is still
-    // possible if the user manually enters CVC, so upload was offered.
-    UPLOAD_OFFERED_NO_CVC = 1 << 8,
+    UPLOAD_NOT_OFFERED_CONFLICTING_NAMES = 1 << 8,
+    // A CVC, one or more valid addresses, and a name were available but the
+    // request to Payments for upload details failed.
+    UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED = 1 << 9,
     // Update |kNumCardUploadDecisionMetrics| when adding new enum here.
   };
 
   enum DeveloperEngagementMetric {
     // Parsed a form that is potentially autofillable and does not contain any
     // web developer-specified field type hint.
     FILLABLE_FORM_PARSED_WITHOUT_TYPE_HINTS = 0,
     // Parsed a form that is potentially autofillable and contains at least one
     // web developer-specified field type hint, a la
     // http://is.gd/whatwg_autocomplete
@@ skipping 738 matching lines @@
     bool logged_suggestion_filled_was_masked_server_card_;
 
     // The last field that was polled for suggestions.
     FormFieldData last_polled_field_;
 
     FormInteractionsUkmLogger*
         form_interactions_ukm_logger_;  // Weak reference.
   };
 
  private:
-  static const int kNumCardUploadDecisionMetrics = 9;
+  static const int kNumCardUploadDecisionMetrics = 10;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_