Change AudioOutputDeviceClientImpl to use WebLocalFrameBase and move to modules.

third_party/WebKit/Source/core/frame/WebLocalFrameBase.h

Index: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
diff --git a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
index 4c412122fca9dcd2ada1ddef45cb69df985a39c3..436d7b6ff06c29661812bdccd760c9b83971792c 100644
--- a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
+++ b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
@@ -1,14 +1,18 @@
 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.#ifndef WebViewBase_h
+// found in the LICENSE file.
 
 #ifndef WebLocalFrameBase_h
 #define WebLocalFrameBase_h
 
+#include "core/CoreExport.h"
+#include "public/platform/WebCommon.h"
 #include "public/web/WebLocalFrame.h"
 
 namespace blink {
 
+class LocalFrame;
+
 // WebLocalFrameBase is a temporary class the provides a layer of abstraction
 // for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl
 // that are not overrides from WebLocalFrame will be declared pure virtual in
@@ -18,9 +22,29 @@ namespace blink {
 // modules.
 // TODO(slangley): Remove this class once WebLocalFrameImpl is in core/.
 class WebLocalFrameBase : public WebLocalFrame {
+ public:
+  // Creation Methods.
+  CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame*);
+  CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame&);
+
+  // WebLocalFrame creation callbacks. These callbacks provide the means to
+  // keep WebLocalFrameBase separate from WebLocalFrameImpl. On process
+  // initialization it is expected that the correct callbacks are registered
+  // so that WebLocalFrameBase can instantiate the concrete class.

[dcheng, 2017/05/05 06:29:58]

I'm really tempted to say that we should just #include WebLocalFrameImpl.h in
WebLocalFrameBase.cpp and avoid the callback indirection. Are there downsides to
doing that, given that this is temporary code?

[slangley, 2017/05/05 09:25:08]

There are scenarios that don't link in libblink_web so we can't do this. Also,
this is not the only use case for this kind of layering, so providing this
mechanism is probably the easiest way to deal with other cases as well (i.e. We
should have done this for WebViewBase & WebViewImpl - right now we downcast.)

[haraken, 2017/05/05 13:48:51]

Yeah, I want to avoid using the callback pattern.

Can we probably use ChromeClient? We can define
ChromeClient::createWebLocalFrameImpl as a virtual method and override the
behavior in ChromeClientImpl.

[slangley, 2017/05/07 00:12:10]

We don't have a way to get a reference to a ChromeClient object (that I can see)
at this point of the code (at least cleanly).

If you're opposed to callbacks how about I create a Factory class that can
instantiate these *Impl types - instead of trying to wedge it into something
like ChromeClient?

[haraken, 2017/05/08 00:01:58]

When you call WebLocalFrameImpl::FromFrame(Frame*), you already have a pointer
to Frame. You can easily get the ChromeClient by frame->page()->chromeClient(),
right?

[slangley, 2017/05/08 01:47:49]

Seems true - i wasn't able to grok that many indirections ;)

Done.

+  using CreateFromLocalFramePtrCallback = WebLocalFrameBase* (*)(LocalFrame*);
+
+  CORE_EXPORT static void RegisterCreateFromLocalFramePtrCallback(
+      CreateFromLocalFramePtrCallback);
+
+  virtual WebFrameClient* Client() const = 0;
+
  protected:
   explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {}
+
+ private:
+  static CreateFromLocalFramePtrCallback create_local_frame_ptr_callback_;
 };
-}
+
+}  // namespace blink
 
 #endif  // WebLocalFrameBase_h