third_party/WebKit/Source/web/WebInitializer.cpp - Issue 2863913002: Change AudioOutputDeviceClientImpl to use WebLocalFrameBase and move to modules.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/WebInitializer.cpp

Issue 2863913002: Change AudioOutputDeviceClientImpl to use WebLocalFrameBase and move to modules. (Closed)

Patch Set: Fix code review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "web/WebInitializer.h"

	6

	7 #include "core/frame/WebLocalFrameBase.h"

	8 #include "web/WebLocalFrameImpl.h"

	9

	10 namespace blink {

	11

	12 void WebInitializer::Initialize() {

	13 // Initialize WebLocalFrameBase with method to construct WebLocalFrameImpl.

	14 WebLocalFrameBase::RegisterCreateFromLocalFramePtrCallback(

	15 [](LocalFrame* frame) {

	16 return static_cast<WebLocalFrameBase*>(
	dcheng 2017/05/05 06:29:58 Nit: I think this static cast isn't needed, as Web Nit: I think this static cast isn't needed, as WebLocalFrameBase is a subclass. slangley 2017/05/05 09:25:08 Doesn't compile without the cast unfortunately - g Show quoted text On 2017/05/05 at 06:29:58, dcheng wrote: > Nit: I think this static cast isn't needed, as WebLocalFrameBase is a subclass. Doesn't compile without the cast unfortunately - get no viable conversion errors.
	17 WebLocalFrameImpl::FromFrame(frame));

	18 });

	19 }

	20

	21 } // namespace blink

OLD	NEW