Issue 2863883002: Tracing for NSMenu timelines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2863883002: Tracing for NSMenu timelines

Created:
3 years, 7 months ago by tapted

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews, tfarina, mac-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Tracing for NSMenu timelines cl format Tracing BUG=

Patch Set 1 #

Patch Set 2 : pump tasks during menu fade #

Patch Set 3 : big CL with more trace points #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+316 lines, -18 lines)			Patch
M	ui/base/cocoa/menu_controller.h	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/base/cocoa/menu_controller.mm	View	1 2	6 chunks	+48 lines, -6 lines	0 comments	Download
M	ui/base/cocoa/menu_controller_unittest.mm	View	1 2	3 chunks	+105 lines, -0 lines	0 comments	Download
M	ui/views/cocoa/bridged_native_widget.h	View	1 2	4 chunks	+13 lines, -2 lines	0 comments	Download
M	ui/views/cocoa/bridged_native_widget.mm	View	1 2	3 chunks	+23 lines, -6 lines	0 comments	Download
M	ui/views/controls/menu/menu_runner_impl_cocoa.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/menu/menu_runner_impl_cocoa.mm	View	1 2	5 chunks	+114 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tapted

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

3 years, 7 months ago (2017-05-08 05:48:53 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863883002/20001

3 years, 7 months ago (2017-05-08 05:49:13 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 7 months ago (2017-05-08 07:04:43 UTC) #3

commit-bot: I haz the power

3 years, 7 months ago (2017-05-08 07:04:43 UTC) #4

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages