Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: content/browser/accessibility/dump_accessibility_browsertest_base.cc

Issue 2863833003: Fix primary cause of flakiness of DumpAccessibilityEvents tests on Win (Closed)
Patch Set: Fix logic Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_browsertest_base.cc
diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.cc b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
index 4ab96336500290e4e7600fde1774f934d93d2205..5e0f88bda2ff94cafda1cc4a287b140148ca14df 100644
--- a/content/browser/accessibility/dump_accessibility_browsertest_base.cc
+++ b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
@@ -195,6 +195,11 @@ void DumpAccessibilityTestBase::RunTestForPlatform(
BrowserAccessibilityStateImpl::GetInstance()->
set_disable_hot_tracking_for_testing(true);
+ // Normally we avoid firing accessibility focus events when the containing
+ // native window isn't focused. Suppress this check to avoid flaky tests,
+ // since we can't always control when a native window loses focus.
+ BrowserAccessibilityManager::NeverSuppressFocusEventsForTesting();
+
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
std::string html_contents;
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698