Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2863833002: Implement inferGenericFunctionOrType in front_end. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -47 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_constraint_gatherer.dart View 6 chunks +44 lines, -45 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 2 chunks +63 lines, -0 lines 2 comments Download
M pkg/front_end/test/fasta/type_inference/type_constraint_gatherer_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/type_inference/type_schema_environment_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-04 23:39:28 UTC) #2
Jennifer Messerly
<L>(G, T) -> M ! lgtm https://codereview.chromium.org/2863833002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart File pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart (right): https://codereview.chromium.org/2863833002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart#newcode184 pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart:184: /// used for ...
3 years, 7 months ago (2017-05-04 23:45:43 UTC) #3
scheglov
LGTM
3 years, 7 months ago (2017-05-04 23:46:46 UTC) #4
Paul Berry
https://codereview.chromium.org/2863833002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart File pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart (right): https://codereview.chromium.org/2863833002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart#newcode184 pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart:184: /// used for downwards inference. If this is the ...
3 years, 7 months ago (2017-05-05 01:17:32 UTC) #5
Paul Berry
3 years, 7 months ago (2017-05-05 01:21:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a59bff34236d6ca0c73429a859d76065c0e92d2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698