Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2863823002: Implement inferTypeFromConstraints in front_end. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement inferTypeFromConstraints in front_end. This is an intermediate algorithm used in type inference. It corresponds to the method _GenericInferrer.infer() in analyzer. R=jmesserly@google.com, scheglov@google.com Note: error reporting will be added in a follow-up CL. Committed: https://github.com/dart-lang/sdk/commit/28f277a7e2304d2afd7e11186b22d4e93a58c048

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -1 line) Patch
M pkg/analyzer_plugin/analyzer_plugin.iml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 3 chunks +144 lines, -0 lines 3 comments Download
M pkg/front_end/test/fasta/type_inference/type_schema_environment_test.dart View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-04 23:03:08 UTC) #2
Jennifer Messerly
lgtm! https://codereview.chromium.org/2863823002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart File pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart (right): https://codereview.chromium.org/2863823002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart#newcode19 pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart:19: DartType lower = const UnknownType(); did you mean ...
3 years, 7 months ago (2017-05-04 23:14:26 UTC) #3
Paul Berry
https://codereview.chromium.org/2863823002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart File pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart (right): https://codereview.chromium.org/2863823002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart#newcode19 pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart:19: DartType lower = const UnknownType(); On 2017/05/04 23:14:26, Jennifer ...
3 years, 7 months ago (2017-05-04 23:27:51 UTC) #4
scheglov
LGTM
3 years, 7 months ago (2017-05-04 23:28:22 UTC) #5
Paul Berry
3 years, 7 months ago (2017-05-04 23:32:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28f277a7e2304d2afd7e11186b22d4e93a58c048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698