Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2863773004: Separate updateComments from updateExpectations. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Separate updateComments from updateExpectations. Previous to this CL, the updateExpectations flag had two effects: - It caused ".expect" files to be updated. - It caused embedded expectations comments in ".dart" files (of the form "/*@key=value*/") to be updated. I'm finding that I frequently want to update the former but not the latter, so I'm splitting this into two separate flags. With this CL, updateExpectations only updates ".expect" files, and updateComments only updates embedded expectations comments. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4e481ccee57ffea9cfbce45000f60a5ae5cd5063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M pkg/front_end/test/fasta/testing/suite.dart View 4 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-05 18:26:49 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-05 18:37:29 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-05 19:04:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e481ccee57ffea9cfbce45000f60a5ae5cd5063 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698