Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html

Issue 2863763003: Remove EventSender from ImageLoader (Closed)
Patch Set: fix tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html b/third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html
index 6235b355d0ed1e235dccb4910501b8e4a5bf332f..2c0e7668e22dcafec05ce4144287aac21388ced9 100644
--- a/third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html
+++ b/third_party/WebKit/LayoutTests/http/tests/multipart/stop-loading.html
@@ -12,6 +12,12 @@ function firstPartLoaded()
assert_true(internals.isLoading(url), "The image should be loading before window.stop().");
}
window.stop();
+
+ // We emulate window load event to signal testharness.js that we don't
kinuko 2017/05/08 09:24:24 nit: that -> so that?
kouhei (in TOK) 2017/05/08 11:54:25 "that" seems correct here?
hiroshige 2017/05/08 19:23:10 Either looks fine to me (with different but accept
+ // have to wait for window load event (that will never occur because
+ // we've called window.stop()) before test completes.
+ dispatchEvent(new Event('load'));
+
window.setTimeout(t.step_func(function() {
if (window.internals) {
assert_false(internals.isLoading(url), "The image should not be loading after window.stop().");

Powered by Google App Engine
This is Rietveld 408576698