Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2863683002: Specify types in generated closure args. (Closed)

Created:
3 years, 7 months ago by pquitslund
Modified:
3 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 3 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
3 years, 7 months ago (2017-05-04 17:59:22 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2863683002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2863683002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode583 pkg/analysis_server/test/services/correction/fix_test.dart:583: typedef int Callback(int a, String b,c); It would ...
3 years, 7 months ago (2017-05-04 18:04:58 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/2863683002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2863683002/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode583 pkg/analysis_server/test/services/correction/fix_test.dart:583: typedef int Callback(int a, String b,c); On 2017/05/04 ...
3 years, 7 months ago (2017-05-04 19:53:59 UTC) #4
pquitslund
3 years, 7 months ago (2017-05-04 19:54:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a394e975f3e95d8bae01a1327a4883a92b1cace (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698