pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart - Issue 2863603004: Fix handling of null/bottom in front_end type inference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

Issue 2863603004: Fix handling of null/bottom in front_end type inference. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart ('k') | pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

index 21d03e5d52d35799d7a70a7a546bb80fc5d3fd43..33568aa7839767198cea240e85546cbd4605641f 100644

--- a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

@@ -139,8 +139,8 @@ abstract class TypeInferenceEngineImpl<F> extends TypeInferenceEngine<F> {

if (fieldHasInitializer(field)) {

var typeInferrer = getFieldTypeInferrer(field);

var type = getFieldDeclaredType(field);

- var inferredType =

- typeInferrer.inferFieldInitializer(field, type, type == null);

+ var inferredType = typeInferrer.inferDeclarationType(

+ typeInferrer.inferFieldInitializer(field, type, type == null));

if (type == null && strongMode) {

instrumentation?.record(

Uri.parse(typeInferrer.uri),