Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(290)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: pkg/front_end/testcases/inference/list_literals.dart.strong.expect
Issue
2863603004
:
Fix handling of null/bottom in front_end type inference. (Closed)
Patch Set:
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
pkg/front_end/test/fasta/strong.status
pkg/front_end/testcases/inference/list_literals.dart
pkg/front_end/testcases/inference/list_literals.dart.strong.expect
pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart
pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart.strong.expect
View unified diff
|
Download patch
« no previous file with comments
|
« pkg/front_end/testcases/inference/list_literals.dart
('k') |
pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
library test;
2
import self as self;
3
import "dart:core" as core;
4
5
static method test1() → dynamic {
6
core::List<core::int> x = <core::int>[1, 2, 3];
7
x.add("hi");
8
x.add(4.0);
9
x.add(4);
10
core::List<core::num> y = x;
11
}
12
static method test2() → dynamic {
13
core::List<core::num> x = <core::num>[1, 2.0, 3];
14
x.add("hi");
15
x.add(4.0);
16
core::List<core::int> y = x;
17
}
18
static method main() → dynamic {
19
self::test1();
20
self::test2();
21
}
OLD
NEW
« no previous file with comments
|
« pkg/front_end/testcases/inference/list_literals.dart
('k') |
pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart »
('j') |
no next file with comments »
Issue 2863603004: Fix handling of null/bottom in front_end type inference. (Closed)
Created 3 years, 7 months ago by Paul Berry
Modified 3 years, 7 months ago
Reviewers: scheglov
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2863603004:
Fix handling of null/bottom in front_end type inference. (Closed)
