Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2863573004: Explicitly tell Smart Select whether or not to suggest (Closed)
Patch Set: fixing nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
index 9bfd26bb04bbd700d3852ad078480fdf5310565d..a2c907d0619731596c2934543e5da172799290a8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
@@ -1209,10 +1209,13 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
}
@Override
- public boolean sendsSelectionPopupUpdates() {
+ public boolean requestSelectionPopupUpdates(boolean shouldSuggest) {
return false;
}
+ @Override
+ public void cancelAllRequests() {}
+
// TODO(donnd): add handling of an ACK to selectWordAroundCaret (crbug.com/435778 has details).
/**
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698