chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java - Issue 2863573004: Explicitly tell Smart Select whether or not to suggest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2863573004: Explicitly tell Smart Select whether or not to suggest (Closed)

Patch Set: Make cancel requests explicit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

index 9bfd26bb04bbd700d3852ad078480fdf5310565d..a2c907d0619731596c2934543e5da172799290a8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

@@ -1209,10 +1209,13 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega

}

@Override

- public boolean sendsSelectionPopupUpdates() {

+ public boolean requestSelectionPopupUpdates(boolean shouldSuggest) {

return false;

}

+ @Override

+ public void cancelAllRequests() {}

// TODO(donnd): add handling of an ACK to selectWordAroundCaret (crbug.com/435778 has details).

/**