Explicitly tell Smart Select whether or not to suggest

content/public/android/java/src/org/chromium/content/browser/SelectionClient.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 /**
  * Interface to a content layer client that can process and modify selection text.
  */
 public interface SelectionClient {
@@ skipping 12 matching lines @@
     void onSelectionEvent(int eventType, float posXPix, float posYPix);
 
     /**
      * Requests to show the UI for an unhandled tap, if needed.
      * @param x The x coordinate of the tap.
      * @param y The y coordinate of the tap.
      */
     void showUnhandledTapUIIfNeeded(int x, int y);
 
     /**
-     * Returns true if the SelectionClient sends responces that can contain information about
-     * the context menu (e.g. that we need a new menu item). In this case an embedder might want
-     * to wait for this responce before taking further actions.
+     * Notifies the SelectionClient that the selection menu has been requested. It returns true if
+     * the embedder should wait for a response before showing the selection menu. The response can
+     * contain information about the selection menu (e.g. that we need a new menu item).
+     * @param shouldSuggest Whether SelectionClient should suggest and classify or just classify.

[Donn Denman, 2017/05/05 01:23:24]

Nit: use @return here.

[amaralp, 2017/05/05 21:18:31]

Done.

      */
-    boolean sendsSelectionPopupUpdates();
+    boolean requestSelectionPopupUpdates(boolean shouldSuggest);
+
+    /**
+     * Cancel any outstanding requests the embedder had previously requested using
+     * SelectionClient.requestSelectionPopupUpdates().
+     */
+    public void cancelAllRequests();
 }