chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc - Issue 2863533003: [EasyUnlock] Serialize and store BeaconSeeds along as cryptohome key metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc

Issue 2863533003: [EasyUnlock] Serialize and store BeaconSeeds along as cryptohome key metadata. (Closed)

Patch Set: [EasyUnlock] Serialize and store BeaconSeeds along as cryptohome key metadata. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc ('k') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc » ('j') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc

diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc

index 1fc777f4afbd305434106a82227339e38f55ef66..aeae6d7d741afb84ff8c75e9ce3dccfd61e8160f 100644

--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc

+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc

@@ -125,6 +125,11 @@ void EasyUnlockGetKeysOperation::OnGetKeyData(

device.wrapped_secret = *entry.bytes;

else

NOTREACHED();

+ } else if (entry.name == kEasyUnlockKeyMetaNameSerializedBeaconSeeds) {

+ if (entry.bytes)

+ device.serialized_beacon_seeds = *entry.bytes;

+ else

+ NOTREACHED();

} else {

PA_LOG(WARNING) << "Unknown Easy unlock key data entry, name="

Ryan Hansberry 2017/05/09 02:44:08 super nit: Not part of this CL but can you fix thi

Tim Song 2017/05/10 18:23:26 Done.

<< entry.name;