Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js

Issue 2863533002: DevTools: Roll lighthouse w/ artifact delivery (Closed)
Patch Set: extra roll of css tweaks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js b/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
index f5318cdaa40481a45d5d8f9b4120a3dafa9c3885..f42b8d6451d3cba5f0026204cc955d6590656bc0 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
@@ -149,7 +149,7 @@ class ReportRenderer {
const categories = reportSection.appendChild(this._dom.createElement('div', 'lh-categories'));
for (const category of report.reportCategories) {
scoreHeader.appendChild(this._categoryRenderer.renderScoreGauge(category));
- categories.appendChild(this._categoryRenderer.render(category));
+ categories.appendChild(this._categoryRenderer.render(category, report.reportGroups));
}
reportSection.appendChild(this._renderReportFooter(report));
@@ -169,8 +169,10 @@ if (typeof module !== 'undefined' && module.exports) {
* id: string,
* weight: number,
* score: number,
+ * group: string,
* result: {
* description: string,
+ * informative: boolean,
* debugString: string,
* displayValue: string,
* helpText: string,
@@ -195,13 +197,23 @@ ReportRenderer.AuditJSON; // eslint-disable-line no-unused-expressions
*/
ReportRenderer.CategoryJSON; // eslint-disable-line no-unused-expressions
+/**
+ * @typedef {{
+ * title: string,
+ * description: string,
+ * }}
+ */
+ReportRenderer.GroupJSON; // eslint-disable-line no-unused-expressions
+
/**
* @typedef {{
* lighthouseVersion: string,
* generatedTime: string,
* initialUrl: string,
* url: string,
+ * artifacts: {traces: !Object},
* reportCategories: !Array<!ReportRenderer.CategoryJSON>,
+ * reportGroups: !Object<string, !ReportRenderer.GroupJSON>,
* runtimeConfig: {
* blockedUrlPatterns: !Array<string>,
* environment: !Array<{description: string, enabled: boolean, name: string}>

Powered by Google App Engine
This is Rietveld 408576698