Issue 286353002: Move ClearBrowsingData from the ToolbarModel to the application

Issue 286353002: Move ClearBrowsingData from the ToolbarModel to the application (Closed)

Created:
6 years, 7 months ago by Ted C

Modified:
6 years, 7 months ago

Reviewers:
Yaron, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ClearBrowsingData from the ToolbarModel to the application BUG=318769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271569

Patch Set 2 : Fix logging tag #

Patch Set 3 : Fix ChromeNativeTestApplication #

Patch Set 4 : Remove OpenClearBrowsingData declaration from tab model test. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -21 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/android/chromium_application.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/android/chromium_application.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/android/tab_model/tab_model.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/android/tab_model/tab_model_base.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/android/tab_model/tab_model_base.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/android/tab_model/tab_model_unittest.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/history_ui.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/test/android/unit_tests_apk/src/org/chromium/chrome/unit_tests_apk/ChromeNativeTestApplication.java	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 13 (0 generated)

Expand Messages | Collapse Messages

Yaron

https://codereview.chromium.org/286353002/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java File chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java (right): https://codereview.chromium.org/286353002/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java#newcode26 chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java:26: private static final String TAG = "ChromiumApplication"; ChromeShellApplication

6 years, 7 months ago (2014-05-17 01:06:11 UTC) #3

Yaron

On 2014/05/17 01:06:11, Yaron wrote: > https://codereview.chromium.org/286353002/diff/1/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java > File > chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java > (right): > > ...

6 years, 7 months ago (2014-05-17 01:06:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/286353002/20001

6 years, 7 months ago (2014-05-19 20:05:31 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/286353002/40001

6 years, 7 months ago (2014-05-19 22:00:53 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/286353002/60001

6 years, 7 months ago (2014-05-20 00:01:43 UTC) #12

Message was sent while issue was closed.

Change committed as 271569

Expand Messages | Collapse Messages