Implement and ship PushManager.supportedContentEncodings

third_party/WebKit/Source/modules/push_messaging/PushManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/push_messaging/PushManager.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
@@ skipping 24 matching lines @@
   return web_push_provider;
 }
 
 }  // namespace
 
 PushManager::PushManager(ServiceWorkerRegistration* registration)
     : registration_(registration) {
   DCHECK(registration);
 }
 
+// static
+Vector<String> PushManager::supportedContentEncodings() {
+  return Vector<String>({"aesgcm"});

[johnme, 2017/05/08 14:36:16]

Nit: should this be an AtomicString?

[Peter Beverloo, 2017/05/08 15:00:11]

That seems a bit excessive. This method is only being called once per
thread(/context) as we cache the result in the bindings code. We wouldn't gain
much.

[johnme, 2017/05/08 15:09:27]

Acknowledged.

+}
+
 ScriptPromise PushManager::subscribe(ScriptState* script_state,
                                      const PushSubscriptionOptionsInit& options,
                                      ExceptionState& exception_state) {
   if (!registration_->active())
     return ScriptPromise::RejectWithDOMException(
         script_state,
         DOMException::Create(kAbortError,
                              "Subscription failed - no active Service Worker"));
 
   const WebPushSubscriptionOptions& web_options =
@@ skipping 58 matching lines @@
       PushSubscriptionOptions::ToWeb(options, exception_state),
       WTF::MakeUnique<PushPermissionStatusCallbacks>(resolver));
   return promise;
 }
 
 DEFINE_TRACE(PushManager) {
   visitor->Trace(registration_);
 }
 
 }  // namespace blink