Implement and ship PushManager.supportedContentEncodings

third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable, v8_value_to_local_cpp_value %}
 
 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
 {%- if attribute.is_data_type_property %}
 const v8::PropertyCallbackInfo<v8::Value>& info
 {%- else %}
 const v8::FunctionCallbackInfo<v8::Value>& info
 {%- endif %}) {
   {% filter format_remove_duplicates(['ExceptionState exceptionState']) %}
   {% set define_exception_state -%}
   ExceptionState exceptionState(info.GetIsolate(), ExceptionState::kGetterContext, "{{interface_name}}", "{{attribute.name}}");
   {%- endset %}
 
   {% if attribute.is_lenient_this %}
   // [LenientThis]
   // Make sure that info.Holder() really points to an instance if [LenientThis].
   if (!{{v8_class}}::hasInstance(info.Holder(), info.GetIsolate()))
     return; // Return silently because of [LenientThis].
   {% endif %}
 
-  {% if not attribute.is_static %}
+  {% if not attribute.is_static or attribute.is_save_same_object %}
   v8::Local<v8::Object> holder = info.Holder();

[Peter Beverloo, 2017/05/05 13:18:59]

SaveSameObject uses |holder| (see lines 27-43 below), but this now introduces a
use of [SaveSameObject] on a static attribute.

Looking at FunctionCallbackInfo<>::Holder(), Ross and I suspect that the holder
ends up being the prototype object as opposed to the instance object, which
should be fine in this case. However, neither of us is sure.

This does work as expected, but verifying this would be most appreciated!

   {% endif %}
 
   {% if attribute.is_save_same_object %}
   // [SaveSameObject]
   {% set same_object_private_key = interface_name + attribute.name[0]|capitalize + attribute.name[1:] %}
   // If you see a compile error that
   //   V8PrivateProperty::GetSameObject{{same_object_private_key}}
   // is not defined, then you need to register your attribute at
   // V8_PRIVATE_PROPERTY_FOR_EACH defined in V8PrivateProperty.h as
   //   X(SameObject, {{same_object_private_key}})
@@ skipping 483 matching lines @@
 static const V8DOMConfiguration::AccessorConfiguration accessorConfiguration[] = {
   {{attribute_configuration(attribute)}}
 };
 for (const auto& accessorConfig : accessorConfiguration)
   V8DOMConfiguration::InstallAccessor(isolate, world, v8::Local<v8::Object>(), prototypeObject, interfaceObject, signature, accessorConfig);
 {% endfilter %}{# runtime_enabled #}
 {% endfilter %}{# secure_context #}
 {% endfilter %}{# exposed #}
 {% endfor %}
 {% endmacro %}