components/reading_list/core/reading_list_model_impl.cc - Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/reading_list/core/reading_list_model_impl.cc

Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests (Closed)

Patch Set: delete unnecessary implementation of Shutdown() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/reading_list/core/reading_list_model_impl.cc

diff --git a/components/reading_list/core/reading_list_model_impl.cc b/components/reading_list/core/reading_list_model_impl.cc

index d1ed193f0b5534f8bfaaf070f9ccf966ac2886bf..92713dbd2cf2b71de76b28d9d45c570cf7b33788 100644

--- a/components/reading_list/core/reading_list_model_impl.cc

+++ b/components/reading_list/core/reading_list_model_impl.cc

@@ -57,7 +57,7 @@ void ReadingListModelImpl::StoreLoaded(

void ReadingListModelImpl::Shutdown() {

DCHECK(CalledOnValidThread());

for (auto& observer : observers_)

- observer.ReadingListModelBeingDeleted(this);

+ observer.ReadingListModelBeingShutdown(this);

loaded_ = false;

}

« no previous file with comments | « no previous file | components/reading_list/core/reading_list_model_observer.h » ('j') | no next file with comments »