Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: tools/testing/dart/record_and_replay.dart

Issue 2863253002: Tighten up a bunch of types in test.dart. (Closed)
Patch Set: Merge branch 'master' into types-for-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/path.dart ('k') | tools/testing/dart/status_expression.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/record_and_replay.dart
diff --git a/tools/testing/dart/record_and_replay.dart b/tools/testing/dart/record_and_replay.dart
index 022c35d02f573561310c6f5210c73f893feb26a1..6f29037b2e5423cc8610b1119e54bd15f396e1f0 100644
--- a/tools/testing/dart/record_and_replay.dart
+++ b/tools/testing/dart/record_and_replay.dart
@@ -34,7 +34,7 @@ import 'test_runner.dart';
*/
List<String> makePathsRelativeToDart(String cwd, List<String> arguments) {
- var relativeArguments = [];
+ var relativeArguments = <String>[];
for (var rawArgument in arguments) {
if (rawArgument.startsWith(cwd)) {
var relative = new Path(rawArgument).relativeTo(new Path(cwd));
@@ -49,7 +49,7 @@ List<String> makePathsRelativeToDart(String cwd, List<String> arguments) {
class TestCaseRecorder {
Path _outputPath;
List<Map> _recordedCommandInvocations = [];
- var _cwd;
+ String _cwd;
TestCaseRecorder(this._outputPath) {
_cwd = Directory.current.path;
@@ -83,7 +83,7 @@ class TestCaseRecorder {
class TestCaseOutputArchive {
Map<String, Map> _commandOutputRecordings;
- var _cwd;
+ String _cwd;
TestCaseOutputArchive() {
_cwd = Directory.current.path;
« no previous file with comments | « tools/testing/dart/path.dart ('k') | tools/testing/dart/status_expression.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698