ProcessManagerFactory: fix dependencies in ApiResourceManager, LazyBgndTaskFactory

extensions/browser/api/api_resource_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_API_RESOURCE_MANAGER_H_
 #define EXTENSIONS_BROWSER_API_API_RESOURCE_MANAGER_H_
 
 #include <map>
 #include <memory>
 
 #include "base/containers/hash_tables.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/scoped_observer.h"
 #include "base/sequence_checker.h"
 #include "base/sequenced_task_runner.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/browser_context_keyed_api_factory.h"
 #include "extensions/browser/extension_registry.h"
+#include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 #include "extensions/browser/process_manager.h"
+#include "extensions/browser/process_manager_factory.h"
 #include "extensions/browser/process_manager_observer.h"
 #include "extensions/common/extension.h"
 
 namespace extensions {
 class CastChannelAsyncApiFunction;
 
 namespace api {
 class BluetoothSocketApiFunction;
 class BluetoothSocketEventDispatcher;
 class SerialEventDispatcher;
@@ skipping 323 matching lines @@
 
   content::NotificationRegistrar registrar_;
   scoped_refptr<ApiResourceData> data_;
 
   ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
       extension_registry_observer_;
   ScopedObserver<ProcessManager, ProcessManagerObserver>
       process_manager_observer_;
 };
 
+template <class T>
+struct BrowserContextFactoryDependencies<ApiResourceManager<T>> {
+  static void DeclareFactoryDependencies(
+      BrowserContextKeyedAPIFactory<ApiResourceManager<T>>* factory) {

[Devlin, 2017/05/12 22:53:59]

Have you done an audit to ensure that all ApiResourceManager implementations
don't implement BrowserContextKeyedAPIFactory::DeclareFactoryDependencies? 
(Otherwise, this wouldn't be called)

[Kevin M, 2017/05/15 18:09:04]

Yes I have. All ApiResourceManagers are produced by
BrowserContextKeyedAPIFactory singletons, or are directly instantiated, as in
the case of webcam_private.

+    factory->DependsOn(
+        ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());
+    factory->DependsOn(ExtensionRegistryFactory::GetInstance());
+    factory->DependsOn(ProcessManagerFactory::GetInstance());
+  }
+};
+
 // With WorkerPoolThreadTraits, ApiResourceManager can be used to manage the
 // lifetime of a set of resources that live on sequenced task runner threads
 // which ApiFunctions use. Examples of such resources are temporary file
 // resources produced by certain API calls.
 //
 // Instead of kThreadId. classes used for tracking such resources should define
 // kSequenceToken and kShutdownBehavior to identify sequence task runner for
 // ApiResourceManager to work on and how pending tasks should behave on
 // shutdown.
 // The user must also define a static const char* service_name() that returns
@@ skipping 42 matching lines @@
         ->GetSequencedTaskRunnerWithShutdownBehavior(
             content::BrowserThread::GetBlockingPool()->GetNamedSequenceToken(
                 T::kSequenceToken),
             T::kShutdownBehavior);
   }
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_API_RESOURCE_MANAGER_H_