Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4902)

Unified Diff: chrome/test/data/webui/settings/test_util.js

Issue 2863213002: MD Settings: Fix and re-enable settings-main tests. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/settings/settings_main_test.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/test_util.js
diff --git a/chrome/test/data/webui/settings/test_util.js b/chrome/test/data/webui/settings/test_util.js
index d6cf3f7b5ca9500fcd759e263b082a7c71446447..4ed76509bed5abefcacfc764012cfe98cbf363cb 100644
--- a/chrome/test/data/webui/settings/test_util.js
+++ b/chrome/test/data/webui/settings/test_util.js
@@ -12,7 +12,12 @@ cr.define('test_util', function() {
* @return {!Promise}
*/
function whenAttributeIs(target, attributeName, attributeValue) {
- function isDone() { return target[attributeName] === attributeValue; }
+ function isDone() {
+ // TODO(dpapad): Following line should check for an attribute, not a
+ // property, meaning target.getAttribute(attributeName). Fix this and
+ // update callers to pass an attribute value instead.
+ return target[attributeName] === attributeValue;
+ }
return isDone() ? Promise.resolve() : new Promise(function(resolve) {
new MutationObserver(function(mutations, observer) {
« no previous file with comments | « chrome/test/data/webui/settings/settings_main_test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698