Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5771)

Unified Diff: chrome/test/data/webui/settings/cr_settings_browsertest.js

Issue 2863213002: MD Settings: Fix and re-enable settings-main tests. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/cr_settings_browsertest.js
diff --git a/chrome/test/data/webui/settings/cr_settings_browsertest.js b/chrome/test/data/webui/settings/cr_settings_browsertest.js
index 0768c5bf7656f80ce670c0cb049e403afde43ed0..d919eb76d3cb474b439e8fd296c6f645fadf7f98 100644
--- a/chrome/test/data/webui/settings/cr_settings_browsertest.js
+++ b/chrome/test/data/webui/settings/cr_settings_browsertest.js
@@ -251,7 +251,6 @@ CrSettingsPeoplePageLockScreenTest.prototype = {
__proto__: CrSettingsBrowserTest.prototype,
/** @override */
- //browsePreload: 'chrome://md-settings/settings_main/settings_main.html',
browsePreload: 'chrome://md-settings/people_page/lock_screen.html',
/** @override */
@@ -1428,11 +1427,10 @@ TEST_F('CrSettingsRouteDynamicParametersTest', 'All', function() {
// Times out on Windows Tests (dbg). See https://crbug.com/651296.
// Times out / crashes on chromium.linux/Linux Tests (dbg) crbug.com/667882
-GEN('#if defined(OS_WIN) || defined(OS_CHROMEOS) || defined(OS_LINUX)' +
- ' || defined(OS_MACOSX)');
-GEN('#define MAYBE_MainPage_All DISABLED_All');
+GEN('#if !defined(NDEBUG)')
+GEN('#define MAYBE_MainPage_All DISABLED_MainPage_All');
GEN('#else');
-GEN('#define MAYBE_MainPage_All All');
+GEN('#define MAYBE_MainPage_All MainPage_All');
GEN('#endif');
/**
@@ -1451,6 +1449,7 @@ CrSettingsMainPageTest.prototype = {
/** @override */
extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
'test_browser_proxy.js',
+ 'test_util.js',
'settings_main_test.js',
]),
};

Powered by Google App Engine
This is Rietveld 408576698