Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: chrome/browser/resources/print_preview/native_layer.js

Issue 2863183004: Print Preview: Fix top level directory compile errors (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/native_layer.js
diff --git a/chrome/browser/resources/print_preview/native_layer.js b/chrome/browser/resources/print_preview/native_layer.js
index c1af357d86969255ba48b6ca6e2ce0cba7ebff80..658b16f7a7332d70b50103f796f629cf1f8a82a7 100644
--- a/chrome/browser/resources/print_preview/native_layer.js
+++ b/chrome/browser/resources/print_preview/native_layer.js
@@ -79,7 +79,7 @@ cr.define('print_preview', function() {
this.onProvisionalDestinationResolved_.bind(this);
global.failedToResolveProvisionalPrinter =
this.failedToResolveProvisionalDestination_.bind(this);
- };
+ }
/**
* Event types dispatched from the Chromium native layer.
@@ -303,9 +303,9 @@ cr.define('print_preview', function() {
'collate': true,
'copies': 1,
'deviceName': destination.id,
- 'dpiHorizontal': "horizontal_dpi" in printTicketStore.dpi.getValue() ?
+ 'dpiHorizontal': 'horizontal_dpi' in printTicketStore.dpi.getValue() ?
printTicketStore.dpi.getValue().horizontal_dpi : 0,
- 'dpiVertical': "vertical_dpi" in printTicketStore.dpi.getValue() ?
+ 'dpiVertical': 'vertical_dpi' in printTicketStore.dpi.getValue() ?
printTicketStore.dpi.getValue().vertical_dpi : 0,
'duplex': printTicketStore.duplex.getValue() ?
NativeLayer.DuplexMode.LONG_EDGE : NativeLayer.DuplexMode.SIMPLEX,
@@ -388,9 +388,9 @@ cr.define('print_preview', function() {
'printWithExtension': destination.isExtension,
'rasterizePDF': printTicketStore.rasterize.getValue(),
'scaleFactor': printTicketStore.scaling.getValueAsNumber(),
- 'dpiHorizontal': "horizontal_dpi" in printTicketStore.dpi.getValue() ?
+ 'dpiHorizontal': 'horizontal_dpi' in printTicketStore.dpi.getValue() ?
printTicketStore.dpi.getValue().horizontal_dpi : 0,
- 'dpiVertical': "vertical_dpi" in printTicketStore.dpi.getValue() ?
+ 'dpiVertical': 'vertical_dpi' in printTicketStore.dpi.getValue() ?
printTicketStore.dpi.getValue().vertical_dpi : 0,
'deviceName': destination.id,
'fitToPageEnabled': printTicketStore.fitToPage.getValue(),
@@ -1002,14 +1002,14 @@ cr.define('print_preview', function() {
/**
* Whether the document has selection.
- * @type {string}
+ * @type {boolean}
dpapad 2017/05/05 23:30:29 Nit (optional): Since you are already doing small
rbpotter 2017/05/06 00:02:19 Done.
* @private
*/
this.documentHasSelection_ = documentHasSelection;
/**
* Whether selection only should be printed.
- * @type {string}
+ * @type {boolean}
* @private
*/
this.selectionOnly_ = selectionOnly;
@@ -1035,7 +1035,7 @@ cr.define('print_preview', function() {
*/
this.serializedDefaultDestinationSelectionRulesStr_ =
serializedDefaultDestinationSelectionRulesStr;
- };
+ }
NativeInitialSettings.prototype = {
/**

Powered by Google App Engine
This is Rietveld 408576698