third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 2863183003: DevTools: report adding mutation event listener as a violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2863183003: DevTools: report adding mutation event listener as a violations. (Closed)

Patch Set: same Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index bbf5555e76997a684dc1058e8642ac4b04f13f1b..31ce0540c78daeebcb6075798defa825f9a56512 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -893,9 +893,10 @@ Console.ConsoleViewMessage = class {

var formattedMessage;

var shouldIncludeTrace = !!this._message.stackTrace &&

(this._message.source === ConsoleModel.ConsoleMessage.MessageSource.Network ||

+ this._message.source === ConsoleModel.ConsoleMessage.MessageSource.Violation ||

this._message.level === ConsoleModel.ConsoleMessage.MessageLevel.Error ||

- this._message.type === ConsoleModel.ConsoleMessage.MessageType.Trace ||

- this._message.level === ConsoleModel.ConsoleMessage.MessageLevel.Warning);

+ this._message.level === ConsoleModel.ConsoleMessage.MessageLevel.Warning ||

+ this._message.type === ConsoleModel.ConsoleMessage.MessageType.Trace);

if (this._message.runtimeModel() && shouldIncludeTrace)

formattedMessage = this._buildMessageWithStackTrace();

else if (this._message.type === ConsoleModel.ConsoleMessage.MessageType.Table)

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp ('k') | no next file » | no next file with comments »