third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp - Issue 2863183003: DevTools: report adding mutation event listener as a violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp

Issue 2863183003: DevTools: report adding mutation event listener as a violations. (Closed)

Patch Set: same Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp

diff --git a/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp b/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp

index 738a0a6d680ac09cd1cb414432e0f2db183a9e60..847f54c899f9df6a24218c945954a264a6cf7558 100644

--- a/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp

+++ b/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp

@@ -284,11 +284,8 @@ void PerformanceMonitor::InnerReportGenericViolation(

if (!location)

location = SourceLocation::Capture(context);

for (const auto& it : *client_thresholds) {

- if (it.value < time) {

- if (!location)

- location = SourceLocation::Capture(context);

+ if (it.value < time)

it.key->ReportGenericViolation(violation, text, time, location.get());

- }

}