Remove override of View::HitTestRect() from BookmarkBarView

Remove override of View::HitTestRect() from BookmarkBarView

The override of View::HitTestRect() in BookmarkBarView checks
for the state of the omnibox popup to determine whether or not the
bookmark bar can accept events. Since this is unrelated to location,
it is better to move this logic into an override of
EventTarget::CanAcceptEvent() instead.

BUG=374340
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272133

[tdanderson, 2014-05-16 19:19:44]

Sadrul, PTAL.

[sadrul, 2014-05-21 15:46:03]

https://codereview.chromium.org/286313003/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/286313003/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:920: return true;
return View::CanAcceptEvent(event)?

[tdanderson, 2014-05-21 21:11:25]

Comment addressed. Sadrul, please take another look.

https://codereview.chromium.org/286313003/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right):

https://codereview.chromium.org/286313003/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:920: return true;
On 2014/05/21 15:46:04, sadrul wrote:
> return View::CanAcceptEvent(event)?

Done.

[sadrul, 2014-05-21 21:55:30]

lgtm

[tdanderson, 2014-05-21 22:29:07]

Scott, can you please take a look?

[sky, 2014-05-21 23:04:58]

LGTM

[tdanderson, 2014-05-21 23:06:44]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-05-21 23:09:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/286313003/40001

[commit-bot: I haz the power, 2014-05-22 08:12:04]

Change committed as 272133

[tdanderson, 2014-05-22 21:18:39]

A revert of this CL has been created in
https://chromiumcodereview.appspot.com/298653007/ by tdanderson@chromium.org.

The reason for reverting is: Items on the bookmark bar can still be highlighted
and tooltips are shown when the omnibox popup is open. tdanderson@ will
investigate..