content/browser/renderer_host/render_view_host_impl.cc - Issue 2863003002: Use the WebContents visibility as the initial visibility when creating a swapped-out RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2863003002: Use the WebContents visibility as the initial visibility when creating a swapped-out RenderView. (Closed)

Patch Set: address comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index f62cf8320202c8cecfe3caa4b1504b320f58ca25..8ccaf1f10a67bc75222dbb6cfb32f178825c5290 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -309,7 +309,8 @@ bool RenderViewHostImpl::CreateRenderView(

params->swapped_out = !is_active_;

params->replicated_frame_state = replicated_frame_state;

params->proxy_routing_id = proxy_route_id;

- params->hidden = GetWidget()->is_hidden();

+ params->hidden = is_active_ ? GetWidget()->is_hidden()

+ : GetWidget()->delegate()->IsHidden();

params->never_visible = delegate_->IsNeverVisible();

params->window_was_created_with_opener = window_was_created_with_opener;

params->enable_auto_resize = GetWidget()->auto_resize_enabled();