cc: Remove CreateAndInitializeOutputSurface from the Proxy interface.

cc: Remove CreateAndInitializeOutputSurface from the Proxy interface.

Move it to be non-virtual methods on SingleThreadProxy and ThreadProxy.
LayerTreeHost only needs to call it on the SingleThreadProxy, and make
it do that before calling Composite() instead of having Composite()
early out.

Merge LTH::InitializeOutputSurfaceIfNeeded into LTH::Composite.

NOTRY=true
R=enne
BUG=374287
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271769

[danakj, 2014-05-16 19:00:04]

A first small step to making OS creation not block in threaded mode.

[enne (OOO), 2014-05-16 20:50:13]

https://codereview.chromium.org/286293002/diff/1/cc/trees/single_thread_proxy.cc
File cc/trees/single_thread_proxy.cc (left):

https://codereview.chromium.org/286293002/diff/1/cc/trees/single_thread_proxy...
cc/trees/single_thread_proxy.cc:343: if
(!layer_tree_host_->InitializeOutputSurfaceIfNeeded())
Should this now DCHECK that the output surface is not lost?

https://codereview.chromium.org/286293002/diff/1/cc/trees/thread_proxy.h
File cc/trees/thread_proxy.h (right):

https://codereview.chromium.org/286293002/diff/1/cc/trees/thread_proxy.h#newc...
cc/trees/thread_proxy.h:151: void CreateAndInitializeOutputSurface();
Can you pick better names to differentiate this and the following function?

[danakj, 2014-05-16 21:02:13]

https://codereview.chromium.org/286293002/diff/1/cc/trees/single_thread_proxy.cc
File cc/trees/single_thread_proxy.cc (left):

https://codereview.chromium.org/286293002/diff/1/cc/trees/single_thread_proxy...
cc/trees/single_thread_proxy.cc:343: if
(!layer_tree_host_->InitializeOutputSurfaceIfNeeded())
On 2014/05/16 20:50:14, enne wrote:
> Should this now DCHECK that the output surface is not lost?

sure.

https://codereview.chromium.org/286293002/diff/1/cc/trees/thread_proxy.h
File cc/trees/thread_proxy.h (right):

https://codereview.chromium.org/286293002/diff/1/cc/trees/thread_proxy.h#newc...
cc/trees/thread_proxy.h:151: void CreateAndInitializeOutputSurface();
On 2014/05/16 20:50:14, enne wrote:
> Can you pick better names to differentiate this and the following function?

I agree, though the following function is being removed in
https://codereview.chromium.org/287193003/. These methods already exist, mind if
I leave them until there?

[danakj, 2014-05-16 21:04:59]

PTAL

[enne (OOO), 2014-05-16 21:05:10]

Sure, lgtm.

[danakj, 2014-05-16 21:30:29]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:34:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/286293002/40001

[danakj, 2014-05-20 15:33:30]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-20 15:34:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/286293002/40001

[danakj, 2014-05-20 16:54:37]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-05-20 16:59:33]

+sky: OWNERS for mojo

This call doesn't make sense with a threaded compositor which Mojo is using, the
output surface is initialized by the scheduler once
SetLayerTreeHostClientReady() happens.

[sky, 2014-05-20 17:34:57]

LGTM

[danakj, 2014-05-20 17:48:27]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-20 17:49:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/286293002/60001

[commit-bot: I haz the power, 2014-05-20 19:41:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-20 20:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:38:42]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[danakj, 2014-05-20 20:42:25]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:43:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/286293002/60001

[commit-bot: I haz the power, 2014-05-20 21:53:17]

Change committed as 271769