Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2862793002: Fix a completion exception during import suggestions. (Closed)

Created:
3 years, 7 months ago by devoncarew
Modified:
3 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a completion exception during import suggestions. BUG= R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/f6f845c879d7f65113e4f1ce5b4e862a76c7b4c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M pkg/analysis_server/analysis_server.iml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 3 chunks +28 lines, -20 lines 0 comments Download
M pkg/analyzer/analyzer.iml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/analyzer_cli.iml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/front_end.iml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
- fix an exception that occurs when we have trouble listing a directory o the ...
3 years, 7 months ago (2017-05-04 07:11:19 UTC) #2
danrubel
LGTM
3 years, 7 months ago (2017-05-04 07:46:58 UTC) #3
devoncarew
3 years, 7 months ago (2017-05-04 16:24:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6f845c879d7f65113e4f1ce5b4e862a76c7b4c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698