src/core/SkMaskFilter.cpp - Issue 286273002: Optimize CSS box-shadow performance by caching the SkMask of the blur effect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkMaskFilter.cpp

Issue 286273002: Optimize CSS box-shadow performance by caching the SkMask of the blur effect. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkMaskFilter.cpp

diff --git a/src/core/SkMaskFilter.cpp b/src/core/SkMaskFilter.cpp

index 8b9792c2c4fbddf182acb3726586709a34a13693..b8e632d0a3b51563f78af98b252a52fd2334e1cb 100644

--- a/src/core/SkMaskFilter.cpp

+++ b/src/core/SkMaskFilter.cpp

@@ -223,7 +223,6 @@ bool SkMaskFilter::filterRRect(const SkRRect& devRRect, const SkMatrix& matrix,

}

draw_nine(patch.fMask, patch.fOuterRect, patch.fCenter, true, clip,

bounder, blitter);

- SkMask::FreeImage(patch.fMask.fImage);

return true;

}

@@ -248,7 +247,6 @@ bool SkMaskFilter::filterPath(const SkPath& devPath, const SkMatrix& matrix,

case kTrue_FilterReturn:

draw_nine(patch.fMask, patch.fOuterRect, patch.fCenter,

1 == rectCount, clip, bounder, blitter);

- SkMask::FreeImage(patch.fMask.fImage);

return true;

case kUnimplemented_FilterReturn:

« no previous file with comments | « no previous file | src/effects/SkBlurMaskFilter.cpp » ('j') | src/effects/SkBlurMaskFilter.cpp » ('J')