Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: components/update_client/updater_state.h

Issue 2862723002: Add updater state for Mac. (Closed)
Patch Set: Added check for nil version in the info.plist. More comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/updater_state.h
diff --git a/components/update_client/updater_state.h b/components/update_client/updater_state.h
index cd537eca589e78f193b72cff37c995ca75957d65..f5cdf553a8d2d963b1b76f8c8b2eb714121e471b 100644
--- a/components/update_client/updater_state.h
+++ b/components/update_client/updater_state.h
@@ -47,8 +47,12 @@ class UpdaterState {
static bool IsJoinedToDomain();
static base::Time GetUpdaterLastStartedAU(bool is_machine);
static base::Time GetUpdaterLastChecked(bool is_machine);
+#if defined(OS_WIN)
Sorin Jianu 2017/05/04 19:53:58 can we avoid conditional compilation in this file?
borisv 2017/05/04 22:19:27 We have to user conditional anyway anyway for the
Sorin Jianu 2017/05/04 22:50:48 wchar_t is a standard type. Also, I can change th
static base::Time GetUpdaterTimeValue(bool is_machine,
const wchar_t* value_name);
+#else
+ static base::Time GetUpdaterTimeValue(const char* value_name);
+#endif
static int GetUpdatePolicy();
static std::string NormalizeTimeDelta(const base::TimeDelta& delta);

Powered by Google App Engine
This is Rietveld 408576698