Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 286263005: Fixes the alignment of the icon and text in the origin chip. (Closed)

Created:
6 years, 7 months ago by macourteau
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes the alignment of the icon and text in the origin chip. The icon was not aligned with the location icon decoration, which means that when the chip was clicked, it would move two pixels to the right, which looked weird. BUG=364119 R=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/origin_chip_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
macourteau
6 years, 7 months ago (2014-05-16 20:13:38 UTC) #1
Scott Hess - ex-Googler
lgtm
6 years, 7 months ago (2014-05-16 22:47:36 UTC) #2
macourteau
The CQ bit was checked by macourteau@chromium.org
6 years, 7 months ago (2014-05-16 23:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/286263005/1
6 years, 7 months ago (2014-05-16 23:33:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 06:00:24 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 17:22:42 UTC) #6
Message was sent while issue was closed.
Change committed as 271242

Powered by Google App Engine
This is Rietveld 408576698