Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 286263004: Remove WebSettings::setFixedPositionCreatesStackingContext. (Closed)

Created:
6 years, 7 months ago by jbroman
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Remove WebSettings::setFixedPositionCreatesStackingContext. After https://codereview.chromium.org/289973008/ lands, there are no remaining call sites. And it's been a no-op for over a month anyhow. BUG=354688 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M public/web/WebSettings.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
6 years, 6 months ago (2014-05-28 02:50:09 UTC) #1
jamesr
lgtm
6 years, 6 months ago (2014-05-28 04:01:14 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 6 months ago (2014-05-28 12:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/286263004/1
6 years, 6 months ago (2014-05-28 12:53:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 13:46:06 UTC) #5
Message was sent while issue was closed.
Change committed as 174969

Powered by Google App Engine
This is Rietveld 408576698