Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 286263002: [DevTools] Notify embedder about pausing/resuming in debugger. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index 12d8f75993131fc5c84d7ce6b2b3ed99f1a11fbe..855e95f2a465c09df7e20059325846b7d9ff36d4 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -120,8 +120,8 @@ private:
// 0. Flush pending frontend messages.
WebViewImpl* viewImpl = WebViewImpl::fromPage(page);
- WebDevToolsAgentImpl* agent = static_cast<WebDevToolsAgentImpl*>(viewImpl->devToolsAgent());
- agent->flushPendingFrontendMessages();
+ WebDevToolsAgentImpl* agentImpl = static_cast<WebDevToolsAgentImpl*>(viewImpl->devToolsAgent());
+ agentImpl->flushPendingFrontendMessages();
Vector<WebViewImpl*> views;
@@ -135,6 +135,8 @@ private:
m_frozenViews.add(view);
views.append(view);
view->setIgnoreInputEvents(true);
+ WebDevToolsAgentImpl* agent = static_cast<WebDevToolsAgentImpl*>(view->devToolsAgent());
pfeldman 2014/05/18 06:10:22 You should do this for this agent only - others do
dgozman 2014/05/19 09:55:49 Done.
+ agent->client()->willEnterModalLoop();
}
// 2. Disable active objects
@@ -151,6 +153,8 @@ private:
if (m_frozenViews.contains(*it)) {
// The view was not closed during the dispatch.
(*it)->setIgnoreInputEvents(false);
+ WebDevToolsAgentImpl* agent = static_cast<WebDevToolsAgentImpl*>((*it)->devToolsAgent());
+ agent->client()->didExitModalLoop();
}
}

Powered by Google App Engine
This is Rietveld 408576698