Issue 2862623002: Add default implementation when fixing missing required closures (flutter-intellij#975)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2862623002: Add default implementation when fixing missing required closures (flutter-intellij#975) (Closed)

Created:
3 years, 7 months ago by pquitslund

Modified:
3 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add default implementation when fixing missing required closures (flutter-intellij#975) Fixes: https://github.com/flutter/flutter-intellij/issues/975 Also improves code generation for required lists to include empty list literals. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/374871da751ad5ca9559c2ae66e451c813adcf15

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -12 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/utilities.dart	View	1 chunk	+14 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	1 chunk	+173 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

3 years, 7 months ago (2017-05-03 20:22:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
374871da751ad5ca9559c2ae66e451c813adcf15 (presubmit successful).