Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 2862583003: Revert of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/better_session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/better_session_restore_browsertest.cc b/chrome/browser/sessions/better_session_restore_browsertest.cc
index e14d8439e9858a2a52cf9e8cc6d60789e5f17f5e..d1bb334903ba95b6a4d243cb9599693eefcc4b55 100644
--- a/chrome/browser/sessions/better_session_restore_browsertest.cc
+++ b/chrome/browser/sessions/better_session_restore_browsertest.cc
@@ -690,27 +690,14 @@
CheckReloadedPageRestored();
}
-// TODO(crbug.com/717740): This test is flaky on Mac.
-#if defined(OS_MACOSX)
-#define MAYBE_PRE_LocalStorageClearedOnExit \
- DISABLED_PRE_LocalStorageClearedOnExit
-#else
-#define MAYBE_PRE_LocalStorageClearedOnExit PRE_LocalStorageClearedOnExit
-#endif
-IN_PROC_BROWSER_TEST_F(RestartTest, MAYBE_PRE_LocalStorageClearedOnExit) {
+IN_PROC_BROWSER_TEST_F(RestartTest, PRE_LocalStorageClearedOnExit) {
StoreDataWithPage("local_storage.html");
CookieSettingsFactory::GetForProfile(browser()->profile())
->SetDefaultCookieSetting(CONTENT_SETTING_SESSION_ONLY);
Restart();
}
-// TODO(crbug.com/717740): This test is flaky on Mac.
-#if defined(OS_MACOSX)
-#define MAYBE_LocalStorageClearedOnExit DISABLED_LocalStorageClearedOnExit
-#else
-#define MAYBE_LocalStorageClearedOnExit LocalStorageClearedOnExit
-#endif
-IN_PROC_BROWSER_TEST_F(RestartTest, MAYBE_LocalStorageClearedOnExit) {
+IN_PROC_BROWSER_TEST_F(RestartTest, LocalStorageClearedOnExit) {
CheckReloadedPageRestored();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698