Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 2862563003: Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 (Closed)
Patch Set: rebase and fix test bugs detected by swarm bot. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index dc37a7a922430b772ddfcfca0f8fbd87da2b877b..ef97215d19abd02e7854bc6eec6b76694c219051 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -2231,6 +2231,10 @@ class HttpStreamFactoryBidirectionalQuicTest
const GURL default_url_;
+ QuicStreamId GetNthClientInitiatedStreamId(int n) {
+ return test::GetNthClientInitiatedStreamId(GetParam(), n);
+ }
+
private:
MockClock clock_;
test::QuicTestPacketMaker client_packet_maker_;
@@ -2265,13 +2269,13 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
mock_quic_data.AddWrite(client_packet_maker().MakeInitialSettingsPacket(
1, &header_stream_offset));
mock_quic_data.AddWrite(client_packet_maker().MakeRequestHeadersPacket(
- 2, test::kClientDataStreamId1, /*should_include_version=*/true,
+ 2, GetNthClientInitiatedStreamId(0), /*should_include_version=*/true,
/*fin=*/true, priority,
client_packet_maker().GetRequestHeaders("GET", "https", "/"),
&spdy_headers_frame_length, &header_stream_offset));
size_t spdy_response_headers_frame_length;
mock_quic_data.AddRead(server_packet_maker().MakeResponseHeadersPacket(
- 1, test::kClientDataStreamId1, /*should_include_version=*/false,
+ 1, GetNthClientInitiatedStreamId(0), /*should_include_version=*/false,
/*fin=*/true, server_packet_maker().GetResponseHeaders("200"),
&spdy_response_headers_frame_length));
mock_quic_data.AddRead(SYNCHRONOUS, ERR_IO_PENDING); // No more read data.
@@ -2393,13 +2397,13 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
mock_quic_data.AddWrite(client_packet_maker().MakeInitialSettingsPacket(
1, &header_stream_offset));
mock_quic_data.AddWrite(client_packet_maker().MakeRequestHeadersPacket(
- 2, test::kClientDataStreamId1, /*should_include_version=*/true,
+ 2, GetNthClientInitiatedStreamId(0), /*should_include_version=*/true,
/*fin=*/true, priority,
client_packet_maker().GetRequestHeaders("GET", "https", "/"),
&spdy_headers_frame_length, &header_stream_offset));
size_t spdy_response_headers_frame_length;
mock_quic_data.AddRead(server_packet_maker().MakeResponseHeadersPacket(
- 1, test::kClientDataStreamId1, /*should_include_version=*/false,
+ 1, GetNthClientInitiatedStreamId(0), /*should_include_version=*/false,
/*fin=*/true, server_packet_maker().GetResponseHeaders("200"),
&spdy_response_headers_frame_length));
mock_quic_data.AddRead(SYNCHRONOUS, ERR_IO_PENDING); // No more read data.
« no previous file with comments | « no previous file | net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698