Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5344)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java

Issue 2862493002: [Android WebAPKs] Add UMA metric for ShellAPK version (Closed)
Patch Set: Merge branch 'master' into metric Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
index 1d4204c61e8f5aa8ba661a7b81ee270f1492c8e0..98cd80e7b4fb7bb19790ce8e9b34c5cc6a1514d7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.metrics;
import org.chromium.base.metrics.RecordHistogram;
+import org.chromium.webapk.lib.common.WebApkConstants;
import java.util.concurrent.TimeUnit;
@@ -95,4 +96,12 @@ public class WebApkUma {
RecordHistogram.recordLongTimesHistogram(
"WebApk.Session.TotalDuration", duration, TimeUnit.MILLISECONDS);
}
+
+ /** Records the current Shell APK version. */
+ public static void recordShellApkVersion(int shellApkVersion, String packageName) {
+ String name = packageName.startsWith(WebApkConstants.WEBAPK_PACKAGE_PREFIX)
+ ? "WebApk.ShellApkVersion.BrowserApk"
+ : "WebApk.ShellApkVersion.UnboundApk";
+ RecordHistogram.recordCountHistogram(name, shellApkVersion);
Ilya Sherman 2017/05/05 22:46:52 I think you wanted to update this line to record a
+ }
}

Powered by Google App Engine
This is Rietveld 408576698